Remove syntax classification lit-based tests
#1966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Jul 31, 2023
There was a problem hiding this comment.
I just looked through the test cases that you didn’t translate to XCTest and I agree that most of them are redundant or pointless with the new SwiftParser implementation. The only exception is that I’d like to have a test case where an escaped keyword is used as an identifier.
|
|
||
| func keywordInCaseAndLocalArgLabel(_ for: Int, for in: Int, class _: Int) { | ||
| // CHECK: <kw>func</kw> <id>keywordInCaseAndLocalArgLabel</id>(<kw>_</kw> <id>for</id>: <type>Int</type>, <id>for</id> <id>in</id>: <type>Int</type>, <id>class</id> <kw>_</kw>: <type>Int</type>) { | ||
| switch(`for`, `in`) { |
There was a problem hiding this comment.
I think some test case with escaped identifiers would be good to keep.
There was a problem hiding this comment.
I think that's good👍. I added two in my new commit in #1953.
|
Otherwise: Thanks a lot for getting rid of |
|
@StevenWong12 Could you rebase this PR? |
Also remove `lit-test-helper` in the codebase
StevenWong12
force-pushed
the
remove_syntax_classification_lit_test
branch
from
26e1416 to
da586f2
Compare
|
@swift-ci Please test |
ahoppen
approved these changes
Aug 4, 2023
|
@swift-ci Please test Windows |
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The follow-up PR for #1953.
Also remove the
lit-test-helperin codebase. 🥳